Skip to content

Remove bundled copy of actions extractor #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2025

Conversation

dbartol
Copy link
Contributor

@dbartol dbartol commented Feb 27, 2025

In #2582, I temporarily added an embedded version of the actions extractor into the CodeQL Action itself, to work around the extractor being omitted from the CLI bundle. That's been fully corrected as of CLI 2.20.4, so we should no longer need the embedded copy.

I'm ignoring the possibility of Advanced Setup users having pinned tools: to a specific version, since the Actions analysis is only in preview anyway.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@Copilot Copilot AI review requested due to automatic review settings February 27, 2025 18:18
@dbartol dbartol requested a review from a team as a code owner February 27, 2025 18:18
@dbartol dbartol requested a review from angelapwen February 27, 2025 18:19
@dbartol
Copy link
Contributor Author

dbartol commented Feb 27, 2025

To be safe, I checked our telemetry and there have been zero runs in the last 14 days that analyzed actions and used a CLI older than 2.20.4.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dbartol dbartol marked this pull request as draft February 27, 2025 19:32
@dbartol
Copy link
Contributor Author

dbartol commented Feb 27, 2025

🤦‍♂️ The autobuild.sh file in the extractor in the CLI doesn't have the execute bit set. I'll have to fix it in the CLI and wait for the newer version to be propagated.

@NlightNFotis NlightNFotis self-assigned this Mar 19, 2025
@aeisenberg
Copy link
Contributor

I will pick this PR up again.

@aeisenberg aeisenberg assigned aeisenberg and unassigned NlightNFotis Apr 2, 2025
@aeisenberg aeisenberg marked this pull request as ready for review April 2, 2025 18:22
@aeisenberg aeisenberg requested review from henrymercer and removed request for angelapwen May 22, 2025 03:40
aeisenberg
aeisenberg previously approved these changes May 22, 2025
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrymercer, I forgot about this PR. Since this is not really my responsibility any more, I'm hoping you can merge this when you're able.

@henrymercer henrymercer enabled auto-merge May 22, 2025 14:38
@henrymercer henrymercer merged commit 5239ab1 into main May 22, 2025
270 checks passed
@henrymercer henrymercer deleted the dbartol/remove-actions-extractor branch May 22, 2025 14:52
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants